Miscellaneous Docker tweaks and fixes#302
Merged
robertbartel merged 9 commits intoNOAA-OWP:masterfrom Mar 22, 2023
Merged
Conversation
Fixing logic where pip installs the updated packages (to avoid the entire image rebuild), so make sure deps are ignored (as this was the slow part).
Adding Docker environment variables to support remote PyCharm debugging, and removing explicit `entrypoint` setting in main stack deployment service config to ensure the included entrypoint.sh script is used.
Fixing issue where somehow (despite this working before) the scripts directory was not recursively being copied (i.e., just the top-level).
Adding the now-required dependency to list of installed apk packages in foundation stage of py-deps image.
robertbartel
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data-serviceimage's entrypoint scriptsubset-serviceDocker servicerequest-service, and update entrypoint script to utilize thesegeos-devtopy-depsimagedmod.clientpackageNote that this PR partially replaces #240, in that it is composed of changes extracted from that PR for easier reviewing and merging.