bug(py38): port functools.cache support#483
Merged
christophertubbs merged 2 commits intoNOAA-OWP:masterfrom Jan 23, 2024
Merged
bug(py38): port functools.cache support#483christophertubbs merged 2 commits intoNOAA-OWP:masterfrom
functools.cache support#483christophertubbs merged 2 commits intoNOAA-OWP:masterfrom
Conversation
Member
Author
|
tests are failing b.c. of something that will be addressed in #424. |
christophertubbs
approved these changes
Jan 23, 2024
Contributor
christophertubbs
left a comment
christophertubbs
left a comment
There was a problem hiding this comment.
Beautiful. I wouldn't have thought of the type guard and I like your use of the tuple check - I don't remember the way I usually do it, but this is better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
ImportError: cannot import name 'cache' from 'functools'bug present in python3.8.dmod.scheduler--0.10.1Changes
ImportError: cannot import name 'cache' from 'functools'bug present in python3.8.