Skip to content

Fix bug with --node-count arg for worker. #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christophertubbs merged 1 commit into from
Aug 16, 2024
Merged

Fix bug with --node-count arg for worker. #701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions python/lib/scheduler/dmod/scheduler/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,8 +403,12 @@ def _generate_docker_cmd_args(self, job: 'Job', worker_index: int) -> List[str]:
raise RuntimeError(f"Unexpected request type {job.model_request.__class__.__name__}: cannot build Docker CMD arg list")

# For now at least, all image args sets will have these (i.e, node count, host string, and job id)
docker_cmd_arg_map = {"--node-count": str(len(job.allocations)), "--host-string": self.build_host_list(job),
"--job-id": str(job.job_id), "--worker-index": str(worker_index)}
docker_cmd_arg_map = {
"--node-count": str(sum(a.cpu_count for a in job.allocations)),
"--host-string": self.build_host_list(job),
"--job-id": str(job.job_id),
"--worker-index": str(worker_index)
}

if isinstance(job.model_request, AbstractNgenRequest):
docker_cmd_arg_map.update(self._generate_nextgen_job_docker_cmd_args(job, worker_index))
Expand Down