Closed
Conversation
groutr
commented
Mar 17, 2025
| import fsspec | ||
|
|
||
| from viz_classes import s3_file, database | ||
| from viz_database import VizDatabase |
Contributor
Author
There was a problem hiding this comment.
The database related changes in this file do seem to rely on #1105.
Merged
shawncrawley
pushed a commit
that referenced
this pull request
Apr 3, 2025
Summary of changes: 1. Reorganize the directory layout for easier development. Uses deploy/code directories to simplify image building. Anything in the deploy/ directory gets uploaded to codebuild and anything in code/ directory gets included in final image. 2. Remove the retry logic from dataset opening/reading. After considering this code for a bit, I don't think we actually execute it in any case short of an S3 outage. 3. Cache S3 file reads locally using fsspec. This uses the new opener interface in rasterio 1.4. Some of the files are opened twice and this should avoid redownloads by caching locally to a temporary directory. 4. Remove the s3_file import and checks file existence directly on S3 via fsspec. 5. Create a new terraform module for hand-fim image. 6. Edit code for better clarity. Supersedes #1108
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorganizes the directory structure to match the latest iteration of the directory structure for an image.