Open
Conversation
Conflict resolved in rebase: Label field added on master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Markus,
Here are some edits that @bergroth made back in March, which I have rebased onto the current master. As far as I can tell there are no conflicts with what has been added to master in the meantime.
I had one merge conflict where both have edited
src/niweb/apps/noclook/templates/noclook/create/create_rack.html(commit 25d0a59), but there was no logical conflict so I simply kept both edits.I have run the tests at
niweb.apps.nerds.testsand all pass. I'm happy to add some new tests also e.g. for the API additions, maybe that would be good. What do you think?