Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .agent/rules/testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
trigger: always_on
---

- Generate unit tests for each file and each method
- Always generate unit tests for each file and each method
- Exception: UI related classes in `valkyrie\unity\Assets\Scripts\UI`
- Unit Tests should always be located in `valkyrie\unity\Assets\UnitTests`
- When new tests have been created/existing tests have been updated ask if Unit tests should be ran. Do not run Unit Tests without confirmation from the user.
Expand Down
2 changes: 1 addition & 1 deletion .agent/rules/text-localization.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ UI text should always get localized. Localization files are located in `Assets/S
- The format is `KEY,Value`.
- When adding new text:
1. Add the `KEY,English Value` to `Localization.English.txt`.
2. **CRITICAL**: Add a translated version `KEY,Translated Value` to *all* other relevant files (`Localization.German.txt`, `Localization.French.txt`, `Localization.Spanish.txt`, `Localization.Italian.txt`, etc.) where the value is translated to the language specified in the filename **IMMEDIATELY**. Do not defer this task. Failing to do so will result in missing text for users of those languages.
2. **CRITICAL**: Add a translated version `KEY,Translated Value` to *all* other relevant files (`Localization.German.txt`, `Localization.French.txt`, `Localization.Spanish.txt`, `Localization.Italian.txt`, etc.) where the value is translated to the language specified in the filename **IMMEDIATELY**. You must not just copy the English text; you must provide a translation. Do not defer this task. Failing to do so will result in missing text for users of those languages.
3. In C# code, use `new StringKey("val", "KEY")` to reference the text.
4. For commonly used keys, add a static reference in `Assets/Scripts/Content/CommonStringKeys.cs`.
5. **VERIFICATION**: Before finishing the task, use find_by_name or list_dir to list all Localization.*.txt files. Confirm that the new key has been added and translated to the respective file language to EACH file. Do not assume; verify.
5 changes: 0 additions & 5 deletions libraries/FFGAppImport/AssetImport/FetchContent.cs
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,6 @@ public FetchContent(FFGImport import)
finder = new MoMFinder(import.platform);
gameType = "MoM";
}
else if (import.type == GameType.IA)
{
finder = new IAFinder(import.platform);
gameType = "IA";
}
else
{
return;
Expand Down
76 changes: 0 additions & 76 deletions libraries/FFGAppImport/AssetImport/IAFinder.cs

This file was deleted.

3 changes: 1 addition & 2 deletions libraries/FFGAppImport/FFGAppImport.cs
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@ public bool Import(string import_path)
public enum GameType
{
D2E,
MoM,
IA
MoM
}

public enum Platform
Expand Down
2 changes: 1 addition & 1 deletion libraries/FFGAppImport/FFGAppImport.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
</ItemGroup>
<ItemGroup>
<Compile Include="AssetImport\AppFinder.cs" />
<Compile Include="AssetImport\IAFinder.cs" />

<Compile Include="AssetImport\ExtractDataTool.cs" />
<Compile Include="AssetImport\FetchContent.cs" />
<Compile Include="AssetImport\FSBExport.cs" />
Expand Down
59 changes: 0 additions & 59 deletions libraries/IADBExtract/IADBExtract.csproj

This file was deleted.

Loading
Loading