New C++ MeasureManager #279
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
commented
Nov 14, 2024
| vm.$log.info('Start Measure Manager Server: ', vm.cliPath, ' measure -s ', vm.port); | ||
| vm.cli = vm.spawn(vm.cliPath, ['classic', 'measure', '-s', vm.port]); | ||
| vm.$log.info('Start Measure Manager Server: ', vm.cliPath, 'measure -s ', vm.port); | ||
| vm.cli = vm.spawn(vm.cliPath, ['measure', '-s', vm.port], { cwd: '.', stdio : 'pipe' }); |
Collaborator
Author
There was a problem hiding this comment.
Not sure whether the { cwd: '.', stdio : 'pipe' } is needed, it was in #267
Comment on lines
+102
to
+105
| // C++ CLI printing errors when requests fail on stderr, eg when post | ||
| // data is missing: | ||
| // [2024-11-14T13:32:17+01:00] "POST /compute_arguments HTTP/1.1" 400 | ||
| vm.$log.error(`MeasureManager: ${data}`); |
Collaborator
Author
There was a problem hiding this comment.
not sure what's wanted here
Comment on lines
+117
to
+126
| vm.cli.on('exit', (code) => { | ||
| if (code !== 0) { | ||
| const msg = `Failed with code = ${code}`; | ||
| console.log(msg); | ||
| } | ||
| }); | ||
|
|
||
| }).catch((err) => { | ||
| vm.$log.error('Error locating an open port for measure manager.'); | ||
| }); |
This was referenced Nov 14, 2024
Closed
jmarrec
force-pushed
the
new-mm-reboot
branch
from
1c71c0c to
9a151c7
Compare
19 tasks
Collaborator
Author
|
@brianlball @DavidGoldwasser @kflemin I can't assign reviewers, but given the discussion about wanting to remove the |
DavidGoldwasser
requested review from
anchapin
and removed request for
wenyikuang
DavidGoldwasser
requested review from
brianlball
and removed request for
anchapin
Collaborator
|
@jmarrec @DavidGoldwasser how should we test this? |
Collaborator
Author
|
I guess make an installer (or build locally) and test it on a couple of projects? How were y'all testing PAT so far? |
Merged
Collaborator
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To only see what I changed after the rebase, the easiest is to go to this PR with comment: jmarrec#1 (review)
You can also just see the last commit: 5a8afe4#diff-fd4f239e9d2dc98194dc1b38ef8202d67ccdd7b75d94a3a32c32c8cd301d0b0cL62-L64