Convert degrees to radians for inplane rotations#82
Open
STREM-hexagon wants to merge 1 commit intoNVIDIA-ISAAC-ROS:mainfrom
Open
Convert degrees to radians for inplane rotations#82STREM-hexagon wants to merge 1 commit intoNVIDIA-ISAAC-ROS:mainfrom
STREM-hexagon wants to merge 1 commit intoNVIDIA-ISAAC-ROS:mainfrom
Conversation
|
Thanks for catching and fixing this, it looks good to me. We will include this fix in the next patch for release-3.2. |
yuanknv
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The numbers for creating the inplane rotations are clearly given in degrees, but the code for creating the rotation matrix expects radians. This PR adds a conversion to fix this.
This fixes #73, but differs from the solution proposed in the issue by making the conversion outside of the loop for efficiency.