-
Notifications
You must be signed in to change notification settings - Fork 563
chore(build): migrate to Poetry 2.x with PEP 621 pyproject.toml #1521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Greptile OverviewGreptile SummarySuccessfully migrated from Poetry 1.8.2 to Poetry 2.2.1 with PEP 621-compliant
The migration is comprehensive and maintains backward compatibility through proper extras definitions.
|
| Filename | Score | Overview |
|---|---|---|
| pyproject.toml | 5/5 | Successfully migrated from Poetry 1.x to PEP 621 standard format with all previous issues addressed (all extras defined, packages field present, protobuf in main dependencies) |
| CONTRIBUTING.md | 5/5 | Updated documentation to reflect Poetry version requirement from >=1.8,<2.0 to >=2.0,<3.0 |
| Dockerfile | 5/5 | Updated POETRY_VERSION to 2.2.1, simplified install commands by combining --all-extras and --with dev, removed redundant install step |
| docs/conf.py | 5/5 | Updated version extraction to read from [project].version instead of [tool.poetry].version |
| qa/Dockerfile.qa | 5/5 | Updated POETRY_VERSION to 2.2.1, simplified install commands, removed redundant install step |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant Repo as Repository
participant Poetry as Poetry 2.2.1
participant CI as CI/CD Pipelines
participant Docs as Documentation
participant Docker as Docker Images
Dev->>Repo: Update pyproject.toml
Note over Repo: Migrate from [tool.poetry]<br/>to [project] (PEP 621)
Dev->>Poetry: Regenerate poetry.lock
Poetry->>Repo: Generate lock file<br/>with Poetry 2.2.1
Dev->>CI: Update workflow files
Note over CI: Set POETRY_VERSION=2.2.1<br/>in all workflows
Dev->>Docker: Update Dockerfiles
Note over Docker: ENV POETRY_VERSION=2.2.1<br/>Simplify install commands
Dev->>Docs: Update docs/conf.py
Note over Docs: Read version from<br/>[project].version
Dev->>Docs: Update CONTRIBUTING.md
Note over Docs: Require Poetry >=2.0,<3.0
CI->>Poetry: Install Poetry 2.2.1
Poetry->>CI: Ready for build/test
Docker->>Poetry: Install dependencies
Poetry->>Docker: Install with --all-extras
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
.gitlab-ci.yml, line 42 (link)syntax: Using
--extras allbut theallextras no longer exists inpyproject.toml. This will cause CI to fail.
10 files reviewed, 7 comments
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…on to [project].version
Documentation preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
11 files reviewed, no comments
a8fe499 to
24b035f
Compare
|
test-build-wheel workflow successful. |
Description