test(cli): add CLI structure tests for nano3 and super3#149
Open
Doondi-Ashlesh wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Open
test(cli): add CLI structure tests for nano3 and super3#149Doondi-Ashlesh wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Doondi-Ashlesh wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Conversation
Add typer.testing.CliRunner-based tests that verify all nano3 and super3 subcommands are importable and correctly registered. These structural tests catch missing subpackages (e.g. the super3/data gap fixed in NVIDIA-NeMo#100) before they reach users, mirroring the existing tests/recipes/embed/test_cli.py pattern. Coverage: - nano3: top-level commands, data prep (pretrain/sft/rl), data import (pretrain/sft/rl) - super3: top-level commands, rl subcommands (rlvr/swe1/swe2/rlhf), data prep (pretrain/sft/rl), data import (pretrain/sft/rl) Signed-off-by: Doondi-Ashlesh <doondiashlesh@gmail.com>
Contributor
Author
|
Hi, following up on this PR, I would like to get your review when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typer.testing.CliRunner-based structure tests for thenano3andsuper3CLI command treestests/recipes/embed/test_cli.pypattern--helpexits cleanly — catching registration errors (e.g. missing subpackages like the one fixed indatasubcommand missing for super3 #100) before they reach usersTest coverage
nano3 (
tests/recipes/nano3/test_cli.py)pretrain,sft,rl,eval,pipe,data,modeldata prepsubcommands:pretrain,sft,rldata importsubcommands:pretrain,sft,rlsuper3 (
tests/recipes/super3/test_cli.py)pretrain,sft,rl,eval,pipe,data,modelrlsubcommands:rlvr,swe1,swe2,rlhfdata prepsubcommands:pretrain,sft,rldata importsubcommands:pretrain,sft,rlTest plan
pytest tests/recipes/nano3/test_cli.py -vpassespytest tests/recipes/super3/test_cli.py -vpasses