chore: Refactor use of directories as docs content#153
Open
mikemckiernan wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Open
chore: Refactor use of directories as docs content#153mikemckiernan wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
mikemckiernan wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Conversation
Signed-off-by: Mike McKiernan <mmckiernan@nvidia.com>
mikemckiernan
force-pushed
the
mmck-use-copydirs
branch
from
80528e7 to
b473ec6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My engineering team might be contributing to this repo in the near future, so in advance, I wanted to make a few suggestions.
I dusted off an old extension that sidesteps the use of the file system links. They are a slight objection for Windows users.
I can share the diffs--minimal and mostly about links--if you like, but you've been replacing the links with
shutil.copydirin CI already, so you might already know what those diffs look like.PTAL and let me know if there's anything you'd like changed.