-
Notifications
You must be signed in to change notification settings - Fork 247
Integrate Automated QDQ placement tool - Part 1 #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Integrate Automated QDQ placement tool - Part 1 #701
Conversation
9c53783 to
f872e70
Compare
|
Hi @gcunhase, could you help me review this PR? thanks! |
bbbc98b to
80792fa
Compare
|
LGTM from my side. Will wait for @gcunhase review. |
|
LGTM, added a few comments, thanks. |
80792fa to
66ef3ad
Compare
66ef3ad to
01b383a
Compare
4545a57 to
be965aa
Compare
843fc1f to
5f7844b
Compare
3fc1ffa to
e07b7e4
Compare
64817f4 to
ef95c8d
Compare
ajrasane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gcunhase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, other changes can be done in #702.
Head branch was pushed to by a user without write access
ef95c8d to
79ee540
Compare
Signed-off-by: Will Guo <willg@nvidia.com>
Signed-off-by: Will Guo <willg@nvidia.com>
Signed-off-by: Will Guo <willg@nvidia.com>
Signed-off-by: Will Guo <willg@nvidia.com>
Signed-off-by: Will Guo <willg@nvidia.com>
79ee540 to
09a91a8
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #701 +/- ##
==========================================
+ Coverage 73.82% 74.16% +0.33%
==========================================
Files 193 195 +2
Lines 19745 20111 +366
==========================================
+ Hits 14577 14915 +338
- Misses 5168 5196 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What does this PR do?
Type of change: new feature
Overview: This PR integrates an automatical QDQ placment tool into ModelOpt.
This PR is the 1/4 parts of the change, it contains the following changes:
Part 1: #701
Part 2: #702
Part 3: #703
Part 4: #704
Usage
Testing
Implement unit tests, all tests could get passed.
Before your PR is "Ready for review"
Additional Information
Summary by CodeRabbit
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.