-
Notifications
You must be signed in to change notification settings - Fork 247
Noeyy/add test cases for the newly added checkpoints on HF #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: noeyy-mino <174223378+noeyy-mino@users.noreply.github.com>
Signed-off-by: noeyy-mino <174223378+noeyy-mino@users.noreply.github.com>
📝 WalkthroughWalkthroughTest utilities and test files updated to support backend availability detection with filtering and model parameterization changes. Deploy utilities now cache available backends at import time and filter configured backends accordingly. Test files updated to use temporary path parameters and NVFP4 model variants instead of FP4. Changes
Sequence Diagram(s)sequenceDiagram
participant App as Application
participant Detect as Backend Detection
participant Deploy as ModelDeployer
participant Filter as Backend Filtering
participant Gen as Deployer Generation
participant Backends as Individual Backends<br/>(trtllm, vllm, sglang)
App->>Detect: Import deploy_utils
Detect->>Backends: Check availability
Backends-->>Detect: Available set
Detect->>App: Cache & print detected backends
App->>Deploy: Create ModelDeployer with config
Deploy->>Filter: Filter configured backends
Filter->>Detect: Get available backends cache
Detect-->>Filter: Available set
Filter-->>Deploy: Filtered backends (unavailable removed)
alt Backends available
Deploy->>Gen: Generate deployers
Gen->>Backends: Initialize each backend
Backends-->>Gen: Deployer instances
Gen-->>Deploy: Deployer list
Deploy-->>App: ModelDeployer instance
else No backends available
Deploy->>Deploy: Return early (no deployers)
Deploy-->>App: Empty or skipped
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@tests/examples/llm_ptq/test_deploy.py`:
- Around line 481-488: The model_id value in the ModelDeployerList entry
(ModelDeployerList with base_model="Qwen/Qwen3-235B-A22B-Thinking-2507")
references a non-existent HF repo
("nvidia/Qwen3-235B-A22B-Thinking-2507-FP4-Eagle3"); update the model_id field
to a real HuggingFace repository—either use the Eagle3 head under nvidia
("nvidia/Qwen3-235B-A22B-Eagle3") or the FP4 Thinking-2507 checkpoint under
NVFP4 ("NVFP4/Qwen3-235B-A22B-Thinking-2507-FP4") depending on whether you need
the Eagle3 head or the FP4-quantized base, and keep the rest of the
ModelDeployerList fields (backend, tensor_parallel_size, mini_sm,
eagle3_one_model) unchanged.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #827 +/- ##
==========================================
- Coverage 74.24% 73.82% -0.43%
==========================================
Files 192 193 +1
Lines 19033 19745 +712
==========================================
+ Hits 14132 14577 +445
- Misses 4901 5168 +267 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What does this PR do?
Type of change: new tests
Overview: Add new test cases for the newly added checkpoints on HuggingFace.
Usage
pytest test_deploy.py --run-release
NoneTesting
None
Before your PR is "Ready for review"
Additional Information
None
Summary by CodeRabbit
New Features
Improvements
Tests
✏️ Tip: You can customize this high-level summary in your review settings.