-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix decoding with ngpu-lm when training (#13994) #13995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix decoding with ngpu-lm when training (#13994) #13995
Conversation
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
@nithinraok The PR looks good, can you take a look if this is something we want to merge ? @hoangtran9122: Do you mind signing the commit and fixing the linting errors ? |
@hoangtran9122 please update manually to the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Please fix the issues with CI.
Yes sure, I'll sign fix it |
Signed-off-by: Hoang Tran <hoang.tch@namitech.io>
4ecde2d
to
c7be903
Compare
update the latest main branch Signed-off-by: Hoang Tran <hoang.tch@namitech.io>
7087c91
to
5c143f5
Compare
5c143f5
to
3879d54
Compare
I think have some difficulties to set the NEMO_REFORMAT_TOKEN for the commit @artbataev |
@hoangtran9122 The problem is with the PR permissions. After reformatting the code, the changes should be pushed back to your (PR) branch, but you disallowed edits. There are 2 options how to fix it:
|
Signed-off-by: Hoang Tran <hoang.tch@namitech.io>
ff9f69c
to
cb86955
Compare
* Fix decoding with ngpu-lm when training (NVIDIA#13994) Signed-off-by: Hoang Tran <hoang.tch@namitech.io> * code_format Signed-off-by: Hoang Tran <hoang.tch@namitech.io> --------- Signed-off-by: Hoang Tran <hoang.tch@namitech.io> Signed-off-by: Amir Hussein <amhussein@nvidia.com>
Important
The
Update branch
button must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Fix illegal CUDA memory error when evaluating using the decoding methods with NGPU-LM while training ASR models.
Collection: asr
Changelog
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information