Skip to content

fix(onboard): add timeout to spawnSync calls to prevent hung processes #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kjw3 merged 10 commits into from
Mar 30, 2026
+11 −0
Merged

fix(onboard): add timeout to spawnSync calls to prevent hung processes #1069

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
57f2c64
fix(onboard): add timeout to spawnSync calls to prevent hung processes
latenighthackathon Mar 29, 2026
f3460d7
fix(onboard): distinguish timeout from other failures in ollama pull
latenighthackathon Mar 29, 2026
7f8a710
Merge remote-tracking branch 'origin/main' into fix/onboard-spawnsync…
latenighthackathon Mar 30, 2026
1fb728e
Merge branch 'main' into fix/onboard-spawnsync-timeout
kjw3 Mar 30, 2026
e20d868
Merge branch 'main' into fix/onboard-spawnsync-timeout
kjw3 Mar 30, 2026
2ac21d6
Merge branch 'main' into fix/onboard-spawnsync-timeout
kjw3 Mar 30, 2026
5217fc5
Merge branch 'main' into fix/onboard-spawnsync-timeout
kjw3 Mar 30, 2026
f4bf684
Merge branch 'main' into fix/onboard-spawnsync-timeout
kjw3 Mar 30, 2026
fa870f9
Merge branch 'main' into fix/onboard-spawnsync-timeout
kjw3 Mar 30, 2026
888868c
Merge branch 'main' into fix/onboard-spawnsync-timeout
kjw3 Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions bin/lib/onboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,6 +680,7 @@ function probeOpenAiLikeEndpoint(endpointUrl, model, apiKey) {
const result = spawnSync("bash", ["-c", cmd], {
cwd: ROOT,
encoding: "utf8",
timeout: 30_000,
env: {
...process.env,
NEMOCLAW_PROBE_API_KEY: apiKey,
Expand Down Expand Up @@ -729,6 +730,7 @@ function probeAnthropicEndpoint(endpointUrl, model, apiKey) {
const result = spawnSync("bash", ["-c", cmd], {
cwd: ROOT,
encoding: "utf8",
timeout: 30_000,
env: {
...process.env,
NEMOCLAW_PROBE_API_KEY: apiKey,
Expand Down Expand Up @@ -869,6 +871,7 @@ function fetchNvidiaEndpointModels(apiKey) {
const result = spawnSync("bash", ["-c", cmd], {
cwd: ROOT,
encoding: "utf8",
timeout: 30_000,
env: {
...process.env,
NEMOCLAW_PROBE_API_KEY: apiKey,
Expand Down Expand Up @@ -922,6 +925,7 @@ function fetchOpenAiLikeModels(endpointUrl, apiKey) {
const result = spawnSync("bash", ["-c", cmd], {
cwd: ROOT,
encoding: "utf8",
timeout: 30_000,
env: {
...process.env,
NEMOCLAW_PROBE_API_KEY: apiKey,
Expand Down Expand Up @@ -959,6 +963,7 @@ function fetchAnthropicModels(endpointUrl, apiKey) {
const result = spawnSync("bash", ["-c", cmd], {
cwd: ROOT,
encoding: "utf8",
timeout: 30_000,
env: {
...process.env,
NEMOCLAW_PROBE_API_KEY: apiKey,
Expand Down Expand Up @@ -1225,8 +1230,13 @@ function pullOllamaModel(model) {
cwd: ROOT,
encoding: "utf8",
stdio: "inherit",
timeout: 600_000,
env: { ...process.env },
});
if (result.signal === "SIGTERM") {
console.error(` Model pull timed out after 10 minutes. Try a smaller model or check your network connection.`);
return false;
}
return result.status === 0;
}

Expand Down Expand Up @@ -1360,6 +1370,7 @@ function installOpenshell() {
env: process.env,
stdio: ["ignore", "pipe", "pipe"],
encoding: "utf-8",
timeout: 300_000,
});
if (result.status !== 0) {
const output = `${result.stdout || ""}${result.stderr || ""}`.trim();
Expand Down
Loading