fix(scripts): redirect all operational log messages to stderr#1072
fix(scripts): redirect all operational log messages to stderr#1072latenighthackathon wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
2be4ba9 to
4194688
Compare
|
✨ Thanks for submitting this PR with a detailed summary, it addresses a bug with operational log messages and proposes a fix to improve the user experience of NemoClaw. |
Redirect all [gateway] and [SECURITY] echo statements to stderr so they do not leak into stdout-captured output (e.g., Telegram bridge responses). Rebased on current main after upstream merges changed nemoclaw-start.sh. Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com>
55a6d6f to
485223e
Compare
Summary
All echo statements in nemoclaw-start.sh wrote to stdout, causing gateway and security log messages to leak into application output. The Telegram bridge captures stdout, so setup messages were prepended to every chat response.
Related Issue
Closes #1064
Changes
Type of Change
Testing
npx prek run --all-filespasses (or equivalentlymake check).npm testpasses.make docsbuilds without warnings. (for doc-only changes)Checklist
General
Code Changes
Summary by CodeRabbit