fix(docker): exclude .venv and dev artifacts from Docker build context#1075
fix(docker): exclude .venv and dev artifacts from Docker build context#1075kjw3 merged 8 commits intoNVIDIA:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe pull request adds six ignore patterns to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
f5616a2 to
54a105f
Compare
|
LGTM |
|
Thanks for taking this on. I agree the The main problem is that the staged onboarding/setup path does not rely on
So this helps a secondary direct-Docker-build path, but it does not fix the main staged local-tree path described in the issue. If you want to revive this, I’d narrow the fix to the staged build context itself:
One separate blocker from our side: the branch tip also needs fully verified signed commits before it would be merge-ready. |
|
Thanks for the detailed breakdown — you're right that the staged build path via Updated the PR description to scope this as a partial fix for the direct I'll also rebase to get verified signatures on all commits. Ready for re-review once that's done. |
Add .venv, .ruff_cache, .mypy_cache, .env, *.egg-info, and .DS_Store to .dockerignore to prevent build context bloat and accidental secret inclusion when using direct docker build. Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com>
3cbafb5 to
68daac3
Compare
Summary
Adds six ignore patterns to
.dockerignoreto exclude local development artifacts from directdocker buildusage, preventing build context bloat and accidental secret inclusion.Scope note: This covers the direct
docker buildpath only. The staged onboarding path (scripts/setup.sh→cp -r) does not honour.dockerignore— extendingscripts/clean-staged-tree.shto cover these patterns is a separate follow-up.Related Issue
Related to #774 (partial fix — direct Docker build path only)
Changes
.venv,.ruff_cache,.mypy_cache,.env,*.egg-info,.DS_Storeto.dockerignore.Testing
.dockerignorepatterns match the artifacts present in a local dev checkout.Checklist
Summary by CodeRabbit