Skip to content

fix(onboard): increase endpoint probe timeout for large model inference #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericksoa wants to merge 1 commit into from
+3 −3
Closed

fix(onboard): increase endpoint probe timeout for large model inference #1080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/lib/onboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ function hydrateCredentialEnv(envName) {
}

function getCurlTimingArgs() {
return ["--connect-timeout 5", "--max-time 20"];
return ["--connect-timeout 10", "--max-time 60"];
}

function buildProviderArgs(action, name, type, credentialEnv, baseUrl) {
Expand Down
4 changes: 2 additions & 2 deletions test/credential-exposure.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ describe("credential exposure in process arguments", () => {
const src = fs.readFileSync(ONBOARD_JS, "utf-8");

expect(src).toMatch(/function getCurlTimingArgs\(\)/);
expect(src).toMatch(/--connect-timeout 5/);
expect(src).toMatch(/--max-time 20/);
expect(src).toMatch(/--connect-timeout 10/);
expect(src).toMatch(/--max-time 60/);
});
});
Loading