ci(nightly-e2e): remove misleading environment from cloud-experimental job #1085
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| #!/usr/bin/env bash | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Shared teardown for e2e-cloud-experimental (extracted from test-e2e-cloud-experimental.sh Phase 0 + Phase 6). | ||
| # | ||
| # Destroys nemoclaw sandbox, OpenShell sandbox, port 18789 forward, and nemoclaw gateway. | ||
| # | ||
| # Usage: | ||
| # SANDBOX_NAME=my-sbx bash test/e2e/e2e-cloud-experimental/cleanup.sh | ||
| # SANDBOX_NAME=my-sbx bash test/e2e/e2e-cloud-experimental/cleanup.sh --verify | ||
| # | ||
| # Environment: | ||
| # SANDBOX_NAME or NEMOCLAW_SANDBOX_NAME — default: e2e-cloud-experimental | ||
| # | ||
| # Modes: | ||
| # (default) — destroy only (best-effort; always exits 0) | ||
| # --verify — destroy then assert sandbox is gone from openshell get + nemoclaw list (exits 1 on failure) | ||
|
|
||
| set -uo pipefail | ||
|
|
||
| pass() { printf '\033[32m PASS: %s\033[0m\n' "$1"; } | ||
| fail() { printf '\033[31m FAIL: %s\033[0m\n' "$1"; } | ||
| skip() { printf '\033[33m SKIP: %s\033[0m\n' "$1"; } | ||
| info() { printf '\033[1;34m [info]\033[0m %s\n' "$1"; } | ||
|
|
||
| SANDBOX_NAME="${NEMOCLAW_SANDBOX_NAME:-${SANDBOX_NAME:-e2e-cloud-experimental}}" | ||
| VERIFY=0 | ||
| if [ "${1:-}" = "--verify" ]; then | ||
| VERIFY=1 | ||
| fi | ||
|
|
||
| info "e2e-cloud-experimental cleanup: sandbox='${SANDBOX_NAME}' (verify=${VERIFY})" | ||
|
|
||
| if command -v nemoclaw >/dev/null 2>&1; then | ||
| nemoclaw "$SANDBOX_NAME" destroy --yes 2>/dev/null || true | ||
| fi | ||
| if command -v openshell >/dev/null 2>&1; then | ||
| openshell sandbox delete "$SANDBOX_NAME" 2>/dev/null || true | ||
| openshell forward stop 18789 2>/dev/null || true | ||
| openshell gateway destroy -g nemoclaw 2>/dev/null || true | ||
| fi | ||
|
|
||
| if [ "$VERIFY" != "1" ]; then | ||
| pass "Cleanup destroy complete (no --verify)" | ||
| exit 0 | ||
| fi | ||
|
|
||
| # ── Post-teardown checks (Phase 6 parity) ── | ||
| if command -v openshell >/dev/null 2>&1; then | ||
| if openshell sandbox get "$SANDBOX_NAME" >/dev/null 2>&1; then | ||
| fail "openshell sandbox get '${SANDBOX_NAME}' still succeeds after cleanup" | ||
| exit 1 | ||
| fi | ||
| pass "openshell: sandbox '${SANDBOX_NAME}' no longer visible to sandbox get" | ||
|
Comment on lines
+50
to
+55
Contributor
There was a problem hiding this comment. Don't treat CLI failures as proof the sandbox is gone.
Also applies to: 60-73 🤖 Prompt for AI Agents |
||
| else | ||
| skip "openshell not on PATH — skipped sandbox get check after cleanup" | ||
| fi | ||
|
|
||
| if command -v nemoclaw >/dev/null 2>&1; then | ||
| set +e | ||
| list_out=$(nemoclaw list 2>&1) | ||
| list_rc=$? | ||
| set -uo pipefail | ||
| if [ "$list_rc" -eq 0 ]; then | ||
| if echo "$list_out" | grep -Fq " ${SANDBOX_NAME}"; then | ||
| fail "nemoclaw list still lists '${SANDBOX_NAME}' after destroy" | ||
| exit 1 | ||
| fi | ||
| pass "nemoclaw list: '${SANDBOX_NAME}' removed from registry" | ||
| else | ||
| skip "nemoclaw list failed after cleanup — could not verify registry (exit $list_rc)" | ||
| fi | ||
| else | ||
| skip "nemoclaw not on PATH — skipped list check after cleanup" | ||
| fi | ||
|
|
||
| pass "Cleanup + verify complete" | ||
| exit 0 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reject unexpected args instead of silently downgrading to destroy-only.
Anything other than exact
--verifycurrently falls through to the success path. A typo here disables the verification gate without failing CI.Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents