Skip to content

fix: use execFile with arg arrays to prevent command injection #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
harshahemanth wants to merge 1 commit into from
+4 −4
Closed

fix: use execFile with arg arrays to prevent command injection #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions nemoclaw/src/commands/status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
// SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// SPDX-License-Identifier: Apache-2.0

import { exec } from "node:child_process";
import { execFile } from "node:child_process";
import { existsSync } from "node:fs";
import { promisify } from "node:util";
import type { PluginLogger, NemoClawConfig } from "../index.js";
import { loadState } from "../blueprint/state.js";

const execAsync = promisify(exec);
const execFileAsync = promisify(execFile);

/**
* Detect whether the plugin is running inside an OpenShell sandbox.
Expand Down Expand Up @@ -128,7 +128,7 @@ async function getSandboxStatus(sandboxName: string, insideSandbox: boolean): Pr
return { name: sandboxName, running: false, uptime: null, insideSandbox: true };
}
try {
const { stdout } = await execAsync(`openshell sandbox status ${sandboxName} --json`, {
const { stdout } = await execFileAsync("openshell", ["sandbox", "status", sandboxName, "--json"], {
timeout: 5000,
});
const parsed = JSON.parse(stdout) as SandboxStatusResponse;
Expand Down Expand Up @@ -162,7 +162,7 @@ async function getInferenceStatus(insideSandbox: boolean): Promise<InferenceStat
return { configured: false, provider: null, model: null, endpoint: null, insideSandbox: true };
}
try {
const { stdout } = await execAsync("openshell inference get --json", {
const { stdout } = await execFileAsync("openshell", ["inference", "get", "--json"], {
timeout: 5000,
});
const parsed = JSON.parse(stdout) as InferenceStatusResponse;
Expand Down