docs: add known issues, hardware details, and NIM warnings to spark-install guide#885
Conversation
…nstall guide Cherry-pick documentation improvements confirmed by reviewers in NVIDIA#304: - Three additional known issues (pip system packages, port 3000 AI Workbench conflict, NVIDIA cloud API egress) - Web Dashboard access section - NIM arm64 compatibility warning - Hardware details (aarch64, 128 GB unified memory, Docker 29.x) Signed-off-by: Maxime Grenu <maxime.grenu@gmail.com>
prekshivyas
left a comment
There was a problem hiding this comment.
Good additions — the new known issues (pip, port 3000, network policy), web dashboard section, and NIM arm64 compatibility warning are all practical, hardware-tested findings.
This needs a rebase on main since #857 (structural restructure of spark-install.md) was just merged. The new sections should slot into #857's structure:
- Known issues rows → Troubleshooting section
- Web dashboard + NIM arm64 → Technical Reference section
Slot PR NVIDIA#885 content into NVIDIA#857 structure per reviewer: known-issue rows to Troubleshooting, Web Dashboard and NIM arm64 to Technical Reference, hardware details to Prerequisites and Architecture diagram.
📝 WalkthroughWalkthroughUpdated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@spark-install.md`:
- Around line 211-213: The doc currently references "~/.openclaw/openclaw.json
inside the sandbox" without showing how to fetch the gateway token; update the
text to explicitly tell users how to retrieve gateway.auth.token by (a) running
jq against /sandbox/.openclaw/openclaw.json from inside the sandbox to extract
gateway.auth.token, or (b) from the host using the sandbox download command
(e.g. openshell sandbox download) to fetch /sandbox/.openclaw/openclaw.json and
then extract gateway.auth.token; retain the note to use 127.0.0.1 for origin
checks.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: fe549f0b-7f5b-49b1-9042-34666955a8a7
📒 Files selected for processing (1)
spark-install.md
| Find your gateway token in `~/.openclaw/openclaw.json` under `gateway.auth.token` inside the sandbox. | ||
|
|
||
| > **Important**: Use `127.0.0.1` (not `localhost`) — the gateway's origin check requires an exact match. External dashboards like Mission Control cannot currently connect due to the gateway resetting `controlUi.allowedOrigins` on every config reload (see [openclaw#49950](https://github.com/openclaw/openclaw/issues/49950)). |
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify how token/config location is documented elsewhere in the repo.
# Expected: consistent guidance for openclaw.json location and token retrieval context.
rg -n -C2 'openclaw\.json|gateway\.auth\.token|127\.0\.0\.1:18789|Web Dashboard|Mission Control'Repository: NVIDIA/NemoClaw
Length of output: 46323
Specify the command or method to retrieve the gateway token for host users.
Line 211 mixes host path notation (~/.openclaw/) with "inside the sandbox," leaving users unclear on how to actually obtain the token for the Web Dashboard URL. Replace the vague reference with an explicit retrieval method. For example:
To retrieve your gateway token, run this command inside the sandbox:
jq -r '.gateway.auth.token' /sandbox/.openclaw/openclaw.json
Or use openshell sandbox download /sandbox/.openclaw/openclaw.json from the host if the sandbox supports it.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@spark-install.md` around lines 211 - 213, The doc currently references
"~/.openclaw/openclaw.json inside the sandbox" without showing how to fetch the
gateway token; update the text to explicitly tell users how to retrieve
gateway.auth.token by (a) running jq against /sandbox/.openclaw/openclaw.json
from inside the sandbox to extract gateway.auth.token, or (b) from the host
using the sandbox download command (e.g. openshell sandbox download) to fetch
/sandbox/.openclaw/openclaw.json and then extract gateway.auth.token; retain the
note to use 127.0.0.1 for origin checks.
There was a problem hiding this comment.
Good point — updated to show the explicit jq command for extracting the token from inside the sandbox. The ~/.openclaw/ path was misleading since the config lives at /sandbox/.openclaw/openclaw.json inside the container.
Summary
Cherry-picks the documentation improvements from #304 that reviewers confirmed are worth merging:
Excludes the install-flow change (handled in #696) and manual openclaw.json editing (needs validation against current gateway config flow).
Supersedes #304.
Test plan
Summary by CodeRabbit
pip installfailures, port 3000 conflicts, and network policy configurations.