feat(sandbox): add registry pull secret support#633
Closed
cheese-head wants to merge 1 commit intoNVIDIA:mainfrom
Closed
feat(sandbox): add registry pull secret support#633cheese-head wants to merge 1 commit intoNVIDIA:mainfrom
cheese-head wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: Patrick Riel <priel@nvidia.com>
|
Thank you for your interest in contributing to OpenShell, @cheese-head. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
|
All contributors have signed the DCO ✍️ ✅ |
Author
|
I have read the DCO document and I hereby sign the DCO. |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add sandbox registry secret management and image pull secret support so private registry images can be used in
openshell sandbox createwithout relying on manual wrapper-image workarounds. This makes private image pulls a first-class sandbox workflow using Kubernetes-nativeimagePullSecrets.Related Issue
Closes #606
Changes
openshell sandbox secret create registryfor creating reusable registry pull secretsopenshell sandbox secret listandopenshell sandbox secret delete--image-pull-secret <name>toopenshell sandbox createSandboxTemplateto carryimage_pull_secretsspec.imagePullSecretsimage_pull_secretsentriesTesting
mise run pre-commitpassesNotes:
cargo fmt --allcargo test -p openshell-clicargo test -p openshell-server image_pull_secretmise run pre-commitwas attempted earlier in this repo, but the full workspace check has unrelated existing failures outside this change setChecklist