[TRTLLM-8269][test] do not explicitly pass temperature=0 to select greedy sampling

[ixlmar]

Description

This is a follow-up to a comment on #7294. Apparently, the changes made to some tests in #7294 are no longer required and hence reverted here.

Note: Second attempt after #7909 was reverted in #8103.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

• New Features

  • CI now recognizes additional evaluation files to trigger multi-GPU tests.

• Refactor

  • Simplified evaluation sampling: removed explicit temperature=0 in JSON-mode and MMLU, relying on defaults while keeping guided decoding unchanged.

• Tests

  • Updated unit and integration tests to reflect default temperature behavior; integration path now sets temperature conditionally based on top_p.

[ixlmar]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #20451 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20451 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15418 completed with status: 'FAILURE'

[ixlmar]

/bot run --stage-list "DGX_H100-4_GPUs-PyTorch-Others-1,DGX_H100-2_GPUs-PyTorch-Others-1"

[tensorrt-cicd]

PR_Github #20474 [ run ] triggered by Bot

[ixlmar]

/bot run --stage-list "DGX_H100-4_GPUs-PyTorch-Others-1,DGX_H100-2_GPUs-PyTorch-Others-1"

[tensorrt-cicd]

PR_Github #20476 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20474 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #15438 (Blue Ocean) completed with status: ABORTED

[ixlmar]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #20479 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20476 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #15441 (Blue Ocean) completed with status: ABORTED

[coderabbitai]

📝 Walkthrough

Walkthrough

Expands multi-GPU file-change detection to include two evaluate files. Removes explicit temperature=0 from sampling in json_mode_eval and MMLU. Adjusts an integration test to conditionally set temperature based on top_p. Updates a unit test to rely on default temperature.

Changes

Cohort / File(s)	Summary
Multi-GPU change detection jenkins/L0_MergeRequest.groovy	Adds tensorrt_llm/evaluate/json_mode_eval.py and tensorrt_llm/evaluate/mmlu.py to the multi-GPU relevant file set.
Evaluate sampling temperature removal tensorrt_llm/evaluate/json_mode_eval.py, tensorrt_llm/evaluate/mmlu.py	Drops explicit temperature=0 from sampling parameters (json_mode_eval sampling_args; MMLU.generate_samples now yields None instead of {"temperature": 0}).
Tests adjustments tests/integration/defs/accuracy/test_disaggregated_serving.py, tests/unittest/llmapi/apps/_test_openai_misc.py	Integration test: conditionally sets temperature (use sampling_params.temperature if top_p set, else 0). Unit test: removes explicit temperature=0 argument.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• [TRTLLM-8269][test] do not explicitly pass temperature=0 to select greedy sampling #7909 — Similar removal of explicit temperature=0 in json_mode_eval.py and mmlu.py with corresponding test updates.
• [TRTLLM-8269][fix] Revert "do not explicitly pass temperature=0 to select greedy sampling" #8103 — Addresses the same temperature handling in json_mode_eval.py and mmlu.py, reverting/adjusting prior changes.

Suggested reviewers

• DomBrown
• Tabrizian

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description clearly explains the purpose of the change and includes the checklist and bot help sections, but it leaves the Test Coverage section empty and omits the summary header from the repository template, resulting in missing critical information on relevant tests.	Please populate the Test Coverage section with the specific tests that validate the reverted behavior and add the summary header as per the repository’s PR description template to ensure all required sections are complete.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title succinctly references the JIRA ticket, indicates it’s a test change, and clearly describes the main change of not explicitly passing temperature=0 for greedy sampling, making it directly relevant and informative for reviewers.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6fd2258 and 9a123d6.

📒 Files selected for processing (5)

• jenkins/L0_MergeRequest.groovy (1 hunks)
• tensorrt_llm/evaluate/json_mode_eval.py (1 hunks)
• tensorrt_llm/evaluate/mmlu.py (1 hunks)
• tests/integration/defs/accuracy/test_disaggregated_serving.py (1 hunks)
• tests/unittest/llmapi/apps/_test_openai_misc.py (0 hunks)

💤 Files with no reviewable changes (1)

• tests/unittest/llmapi/apps/_test_openai_misc.py

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

• tensorrt_llm/evaluate/mmlu.py
• tensorrt_llm/evaluate/json_mode_eval.py
• tests/integration/defs/accuracy/test_disaggregated_serving.py

**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

• tensorrt_llm/evaluate/mmlu.py
• tensorrt_llm/evaluate/json_mode_eval.py
• tests/integration/defs/accuracy/test_disaggregated_serving.py

**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

• tensorrt_llm/evaluate/mmlu.py
• tensorrt_llm/evaluate/json_mode_eval.py
• tests/integration/defs/accuracy/test_disaggregated_serving.py

🧬 Code graph analysis (1)

tensorrt_llm/evaluate/json_mode_eval.py (1)

tensorrt_llm/sampling_params.py (1)

• GuidedDecodingParams (15-37)

🔇 Additional comments (3)

tensorrt_llm/evaluate/json_mode_eval.py (1)

66-68: LGTM! Correctly removes explicit temperature setting.

The removal of "temperature": 0 aligns with the PR objective to rely on default greedy sampling behavior instead of explicitly passing temperature=0.

tests/integration/defs/accuracy/test_disaggregated_serving.py (1)

233-243: Remove or justify the explicit temperature=0 fallback
This test still conditionally assigns temperature=0 when sampling_params.top_p is None (lines 238–240), which conflicts with the PR’s goal to avoid explicitly passing temperature=0. Either remove this assignment to match the other tests, document why this file needs special handling, or confirm that the original LLM limitation (FIXME) has been resolved.

tensorrt_llm/evaluate/mmlu.py (1)

222-222: Sampling args None handled correctly _get_sampline_params skips overrides when sampling_args is None, so the change is safe—no further action needed.

[tensorrt-cicd]

PR_Github #20479 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15444 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.