Skip to content

Conversation

shengfangd
Copy link
Collaborator

Description

QA will use the pytest XML report for auto-triage. Some of the pytorch tests use pytest but do not output the xml report. Add XML reports for all tests that use pytest.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Add pytest xml report for below tests:

  1. L0_pytorch_debug_unittest
  2. L1_pytorch_onnx_unittest
  3. L1_pytorch_distributed_unittest

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: erindai <shengfangd@nvidia.com>
@KshitijLakhani
Copy link
Collaborator

/te-ci

KshitijLakhani
KshitijLakhani previously approved these changes Sep 19, 2025
Copy link
Collaborator

@KshitijLakhani KshitijLakhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
Sanity ran the CI pipeline but I expect no issues. Can be merged once the CI pipeline has finished.

Also, would be good to address one suggested change (not related to this PR) based on responses received

timmoon10
timmoon10 previously approved these changes Sep 19, 2025
Signed-off-by: erindai <shengfangd@nvidia.com>
@shengfangd shengfangd dismissed stale reviews from timmoon10 and KshitijLakhani via 85e663d September 19, 2025 15:19
@KshitijLakhani KshitijLakhani self-requested a review September 22, 2025 17:21
Copy link
Collaborator

@KshitijLakhani KshitijLakhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one change to remove the duplicate line for running the test since my last approval so looks good to me

@shengfangd shengfangd merged commit 2db20a6 into main Sep 23, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants