Conversation
…e "memory", "pcie", "diagnostic" instead of detailed descriptions like "presence of drivers on the denylist (e.g. nouveau)". Signed-off-by: Vadym Fedorov <vfedorov@nvidia.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #97 by modifying diagnostic test name handling to return category names (e.g., "memory", "pcie", "diagnostic") instead of detailed descriptions (e.g., "presence of drivers on the denylist (e.g., nouveau)").
- Removes the
swTestNamefunction that returned detailed descriptions - Updates
newDiagResultto usegpuTestNamewith lowercase conversion - Adds comprehensive test coverage to validate the new TestName format
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/dcgm/diag.go | Removes detailed description function and updates test name logic to use category names |
| tests/diag_test.go | Adds test to validate TestName format contains category names, not descriptions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Vadym Fedorov <vfedorov@nvidia.com>
glowkey
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix correctly addresses issue #97 by returning category names like "memory", "pcie", "diagnostic" instead of detailed descriptions like "presence of drivers on the denylist (e.g., nouveau)".