Skip to content

issue #97 - fix#100

Merged
glowkey merged 2 commits intomainfrom
issue#97
Oct 14, 2025
Merged

issue #97 - fix#100
glowkey merged 2 commits intomainfrom
issue#97

Conversation

@nvvfedorov
Copy link
Collaborator

The fix correctly addresses issue #97 by returning category names like "memory", "pcie", "diagnostic" instead of detailed descriptions like "presence of drivers on the denylist (e.g., nouveau)".

…e "memory", "pcie", "diagnostic" instead of detailed descriptions like "presence of drivers on the denylist (e.g. nouveau)".

Signed-off-by: Vadym Fedorov <vfedorov@nvidia.com>
@nvvfedorov nvvfedorov requested review from Copilot and glowkey October 14, 2025 01:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #97 by modifying diagnostic test name handling to return category names (e.g., "memory", "pcie", "diagnostic") instead of detailed descriptions (e.g., "presence of drivers on the denylist (e.g., nouveau)").

  • Removes the swTestName function that returned detailed descriptions
  • Updates newDiagResult to use gpuTestName with lowercase conversion
  • Adds comprehensive test coverage to validate the new TestName format

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
pkg/dcgm/diag.go Removes detailed description function and updates test name logic to use category names
tests/diag_test.go Adds test to validate TestName format contains category names, not descriptions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: Vadym Fedorov <vfedorov@nvidia.com>
@glowkey glowkey merged commit ec610e8 into main Oct 14, 2025
1 check passed
@glowkey glowkey deleted the issue#97 branch October 14, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants