Conversation
Signed-off-by: Vadym Fedorov <vfedorov@nvidia.com>
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the DCGM diagnostic info message handling to return complete information instead of truncating to only the first matching message. The primary change is in the getInfoMsg function which now concatenates all matching info messages with a pipe separator instead of returning only the first one.
- Updated
getInfoMsgfunction to collect and concatenate all matching diagnostic info messages - Added comprehensive test coverage for the modified diagnostic message handling functionality
- Added helper functions to support testing of DCGM diagnostic responses
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/dcgm/diag.go | Modified getInfoMsg to collect all matching messages and join them with " | " separator |
| pkg/dcgm/diag_test.go | Added comprehensive test suite covering various scenarios for the updated message handling |
| pkg/dcgm/diag_test_helpers.go | Added helper functions for creating test diagnostic responses and managing test data |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.