Skip to content

Fix race condition in config-manager when label is unset #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uristernik wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix race condition in config-manager when label is unset #1541

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a931be
Fix race condition in config-manager when label is unset
uristernik Nov 30, 2025
403778c
CR suggestion
uristernik Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions cmd/config-manager/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ type SyncableConfig struct {
cond *sync.Cond
mutex sync.Mutex
current string
lastRead string
lastRead *string
}

// NewSyncableConfig creates a new SyncableConfig
Expand All @@ -106,11 +106,12 @@ func (m *SyncableConfig) Set(value string) {
func (m *SyncableConfig) Get() string {
m.mutex.Lock()
defer m.mutex.Unlock()
if m.lastRead == m.current {
if m.lastRead != nil && *m.lastRead == m.current {
m.cond.Wait()
}
m.lastRead = m.current
return m.lastRead
val := m.current
m.lastRead = &val
return *m.lastRead
}

func main() {
Expand Down