Skip to content

Conversation

@elezar
Copy link
Member

@elezar elezar commented Dec 4, 2025

This change ensures that tegra-based systems also include a
enable-cuda-compat hook. In the case of Orin devices, this
compat root in the container is set to /usr/local/cuda/compat-orin
to allow these compat libraries to be selected (if present in the
container).

See #1271

@elezar elezar added this to the v1.19.0 milestone Dec 4, 2025
@elezar elezar force-pushed the forward-compat-tegra branch 2 times, most recently from d0f6823 to afb5090 Compare December 4, 2025 15:03
@elezar elezar marked this pull request as draft December 4, 2025 15:22
@elezar elezar force-pushed the forward-compat-tegra branch from afb5090 to 8415215 Compare December 4, 2025 15:29
@coveralls
Copy link

coveralls commented Dec 4, 2025

Pull Request Test Coverage Report for Build 20030163975

Details

  • 3 of 84 (3.57%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 36.927%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/nvidia-cdi-hook/cudacompat/cudacompat.go 3 4 75.0%
internal/modifier/gated.go 0 1 0.0%
pkg/nvcdi/driver-nvml.go 0 1 0.0%
internal/discover/compat_libs.go 0 4 0.0%
pkg/nvcdi/lib-csv.go 0 74 0.0%
Totals Coverage Status
Change from base Build 20029727266: -0.1%
Covered Lines: 5203
Relevant Lines: 14090

💛 - Coveralls

@elezar elezar force-pushed the forward-compat-tegra branch from 8415215 to 18657d5 Compare December 8, 2025 09:00
@elezar elezar marked this pull request as ready for review December 8, 2025 09:07
@elezar elezar requested review from ArangoGutierrez and tariq1890 and removed request for tariq1890 December 8, 2025 09:07
@elezar elezar self-assigned this Dec 8, 2025
@elezar elezar added the tegra label Dec 8, 2025
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Only a typo

@elezar elezar force-pushed the forward-compat-tegra branch 2 times, most recently from 06710de to bab2ffd Compare December 8, 2025 12:34
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This change ensures that tegra-based systems also include a
enable-cuda-compat hook. In the case of Orin devices, this
compat root in the container is set to /usr/local/cuda/compat-orin
to allow these compat libraries to be selected (if present in the
container).

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar force-pushed the forward-compat-tegra branch from bab2ffd to c8056eb Compare December 8, 2025 13:42
@elezar elezar merged commit 4fbb11e into NVIDIA:main Dec 8, 2025
16 checks passed
@elezar elezar deleted the forward-compat-tegra branch December 8, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants