Skip to content

transport: Implement EFA fabric type selection using NVSHMEM_DISABLE_LIBFABRIC_EFA_DIRECT #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nmazzilli3 wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

transport: Implement EFA fabric type selection using NVSHMEM_DISABLE_LIBFABRIC_EFA_DIRECT #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c74a4e
transport/common: Adding environmental variable NVSHMEM_DISABLE_LIBFA…
nmazzilli3 Nov 20, 2025
642cffc
transport/libfabric: Implement EFA fabric type selection using NVSHME…
nmazzilli3 Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/modules/transport/common/env_defs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ NVSHMEMI_ENV_DEF(DISABLE_LOCAL_ONLY_PROXY, bool, false, NVSHMEMI_ENV_CAT_TRANSPO
NVSHMEMI_ENV_DEF(LIBFABRIC_PROVIDER, string, "cxi", NVSHMEMI_ENV_CAT_TRANSPORT,
"Set the feature set provider for the libfabric transport: cxi, efa, verbs")

NVSHMEMI_ENV_DEF(DISABLE_LIBFABRIC_EFA_DIRECT, bool, false, NVSHMEMI_ENV_CAT_TRANSPORT,
"Disable EFA direct fabric and use efa instead")

#if defined(NVSHMEM_IBGDA_SUPPORT) || defined(NVSHMEM_ENV_ALL)
/** GPU-initiated communication **/
NVSHMEMI_ENV_DEF(IBGDA_ENABLE_MULTI_PORT, bool, false, NVSHMEMI_ENV_CAT_TRANSPORT,
Expand Down
7 changes: 5 additions & 2 deletions src/modules/transport/libfabric/libfabric.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1907,7 +1907,7 @@ static int nvshmemt_libfabric_finalize(nvshmem_transport_t transport) {
return 0;
}

static int nvshmemi_libfabric_init_state(nvshmem_transport_t t, nvshmemt_libfabric_state_t *state) {
static int nvshmemi_libfabric_init_state(nvshmem_transport_t t, nvshmemt_libfabric_state_t *state, struct nvshmemi_options_s *options) {
struct fi_info info;
struct fi_tx_attr tx_attr;
struct fi_rx_attr rx_attr;
Expand Down Expand Up @@ -1952,6 +1952,9 @@ static int nvshmemi_libfabric_init_state(nvshmem_transport_t t, nvshmemt_libfabr
FI_MR_LOCAL | FI_MR_VIRT_ADDR | FI_MR_ALLOCATED | FI_MR_PROV_KEY | FI_MR_HMEM;
info.caps |= FI_MSG;
info.caps |= FI_SOURCE;
if (options->DISABLE_LIBFABRIC_EFA_DIRECT) {
info.fabric_attr->name = strdup("efa");
}
}

if (use_staged_atomics) {
Expand Down Expand Up @@ -2209,7 +2212,7 @@ int nvshmemt_init(nvshmem_transport_t *t, struct nvshmemi_cuda_fn_table *table,
#undef NVSHMEMI_SET_ENV_VAR

/* Prepare fabric state information. */
status = nvshmemi_libfabric_init_state(transport, libfabric_state);
status = nvshmemi_libfabric_init_state(transport, libfabric_state, &options);
if (status) {
NVSHMEMI_ERROR_JMP(status, NVSHMEMX_ERROR_INTERNAL, out_clean,
"Failed to initialize the libfabric state.\n");
Expand Down