Fix mask generation in base_loader when reading an image#135
Open
rod409 wants to merge 1 commit intoNVIDIA:mainfrom
Open
Fix mask generation in base_loader when reading an image#135rod409 wants to merge 1 commit intoNVIDIA:mainfrom
rod409 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request proposes a bug fix. In base_loader.py, the read_images function generates a mask without checking keys in an original copy. This causes problems on some datasets where mask values are incorrectly replaced. The change would make the mask generation in the base_loader.py match the method used in uniform.py.
semantic-segmentation/datasets/base_loader.py
Lines 176 to 178 in 7726b14
semantic-segmentation/datasets/uniform.py
Lines 112 to 115 in 7726b14