Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5b464a5 to
e53ec4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #2315
improvements to CSCL diff generation and the QA app CSCL page
poc_validation/scriptsrun_validation.py(new) — generates diffs by streaming dev and prod files directly from S3, no disk usage for inputs, no full build requiredvalidate_outputs.sh— writesvalidation_summary.csvwith per-file prod row counts;mkdir -pso it's re-runnable; adds a note thatrun_validation.pyis now the primary methodsummarize_diffs.py— readsvalidation_summary.csvto add# of rows in prodand% of rows with diffscolumns to the summary CSVQA app
etl_dev_qamodels (LION DAT, ThinLION, RPL) grouped by output type