Merged
Conversation
charmingduchess
requested review from
yossariano
and removed request for
tatianacrainenypl
yossariano
approved these changes
Apr 14, 2026
|
|
||
| def __init__(self, client_id=None, client_secret=None, base_url=None, | ||
| token_url=None, with_retries=False): | ||
| token_url=None, with_retries=False, timeoutInSeconds=None): |
Contributor
There was a problem hiding this comment.
Sorry to be a curmudgeon but can we match variable name format i.e. timeout_in_seconds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sierra token requests are taking a very long time, and causing our lambdas to timeout. Adding a timeout param so the requests fail before the lambda spins down.