Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7emansell
requested changes
Apr 22, 2026
Collaborator
7emansell
left a comment
7emansell
left a comment
There was a problem hiding this comment.
Tests look great just a couple notes
| readonly search_dropdown: Locator | ||
| readonly search_input: Locator | ||
| readonly search_submit_button: Locator | ||
| readonly searchResultsAuthor: Locator |
Collaborator
There was a problem hiding this comment.
is this being used anywhere?
Collaborator
Author
There was a problem hiding this comment.
nope. I'll remove it.
Collaborator
There was a problem hiding this comment.
nit: please rename this folder lowercase to be consistent with the other directories
|
|
||
| ### Added | ||
|
|
||
| - Added Playwright tests for Author Browse [SCC-5338](https://newyorkpubliclibrary.atlassian.net/browse/SCC-5338) |
Collaborator
There was a problem hiding this comment.
please move this into the prerelease section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket:
This PR does the following:
How has this been tested?
Accessibility concerns or updates
Checklist: