Skip to content

SCC-5307: NYQL dropdown and banner#730

Open
7emansell wants to merge 26 commits intomainfrom
SCC-5307/fe-nyql-mvp
Open

SCC-5307: NYQL dropdown and banner#730
7emansell wants to merge 26 commits intomainfrom
SCC-5307/fe-nyql-mvp

Conversation

@7emansell
Copy link
Copy Markdown
Collaborator

@7emansell 7emansell commented Apr 22, 2026

Ticket:

This PR does the following:

  • Adds query to dropdown
  • Adds banner set to appear once
  • Adds 422 error case (invalid query)

** Query guide link won't work yet bc the libguides page doesn't exist, note to self to check before deployment

How has this been tested?

Accessibility concerns or updates

Checklist:

  • I updated the CHANGELOG with the appropriate information and JIRA ticket number (if applicable).
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
research-catalog Ready Ready Preview, Comment Apr 22, 2026 5:11pm

Request Review

Comment thread src/config/appConfig.ts Outdated
Comment thread src/components/Error/ResultsError.tsx Outdated
Comment thread src/server/api/search.ts
Comment thread src/server/api/search.ts Outdated
Comment thread src/utils/searchUtils.ts
{ name: "issn", label: "ISSN" },
{ name: "lccn", label: "LCCN" },
{ name: "callnumber", label: "call number" },
{ name: "cql", label: "query" },
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this label seems a little ambiguous. is this what the discovery API expects?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@charmingduchess charmingduchess self-requested a review April 22, 2026 18:01
@charmingduchess
Copy link
Copy Markdown
Contributor

You mentioned offline that there might be some forthcoming error handling stuff to work out -- is that still TK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants