This repository was archived by the owner on Apr 29, 2021. It is now read-only.
Merging in WilliamMena's experiment branch.#238
Open
WilliamMena wants to merge 35 commits intoNYPL:developmentfrom
Open
Merging in WilliamMena's experiment branch.#238WilliamMena wants to merge 35 commits intoNYPL:developmentfrom
WilliamMena wants to merge 35 commits intoNYPL:developmentfrom
Conversation
* development: (134 commits) Updating unit tests. Fixing unit tests. Fixing sending age group data. Updating BookPage variables. First overhaul of adding tweaks to the staff list title and updating store values and action functions. Investigating travis config Investigating Travis deployment Updated better wording. Removed unnecessary vairiables. Stubbing action. Updating routes for individual pages. Updated the hierachy of test structcures. Updated the endpoint URL to point to configuration files. WWW-17 Resetting base route to baseUrl. WWW-17 Using config.baseUrl instead of hardcoding. Updated better wording. Updated the version and change logs. Created a new version of change on CHANGELOG.md Linted monthData.js WWW-17 Removing .jsx extensions from import statements. ...
* development: Updating the staff pick by line.
* development: Updating unit test. Testing -1 tabindex on book cards. update update og/twitter content to new blurb
* development: Small change to fix a specific width. Adding a bit of documentation. Addin more footer overrides coming from normalize and just general global rules which should be fixed. Meant to write 0. Small CSS override to the footer list item.
* development: Fixing large viewport footer social icon misalignment.
* development: Updating unit test. Small content change.
* development: Updating the Header and Footer components.
* development: Bumping up header component version.
* qa: Bumping up header component version. Updating the Header and Footer components. Updated header to 2.4.9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I've updated the filter buttons to match the buttons on the rest of the application. Also I've added 'authenticate: false' when calling the nyplApiClient so we can access the API read data without needing to have a clientID and SECRET.