Fix infinite retry loop for corrupted audio files #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broaden exception handler in run_analysis() from (NameError, TypeError) to Exception to prevent infinite retry loops when librosa.load() fails. Previous behavior: - NameError/TypeError: file processed with empty detections, deleted - Other exceptions (ValueError, RuntimeError, audioread.DecodeError): propagated to process_file(), file NOT deleted, retried on restart - This caused infinite loops when a corrupted file kept failing New behavior: - All Python exceptions: file processed with empty detections, deleted - Prevents infinite retry loops for corrupted/malformed audio files - Improved logging: shows filename and exception type for debugging This is a bug fix, not a breaking change. The "keep retrying forever" behavior for non-NameError/TypeError exceptions was unintended. Note: C-level crashes (segfaults from ffmpeg/libsndfile) are still not catchable by Python and require the quarantine script approach.
|
This is a good idea I encountered this bug once that was a bit annoying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broaden exception handler in run_analysis() from (NameError, TypeError) to Exception to prevent infinite retry loops when librosa.load() fails.
Previous behavior:
New behavior:
This is a bug fix, not a breaking change. The "keep retrying forever" behavior for non-NameError/TypeError exceptions was unintended.
Note: C-level crashes (segfaults from ffmpeg/libsndfile) are still not catchable by Python manual intervention to delete corrupted files in the backlog