Skip to content

fix(ci): align vibecoder workflows with npm and current trivy action#2

Merged
Nadav011 merged 1 commit intomasterfrom
fix/npm-lock-and-trivy
Mar 29, 2026
Merged

fix(ci): align vibecoder workflows with npm and current trivy action#2
Nadav011 merged 1 commit intomasterfrom
fix/npm-lock-and-trivy

Conversation

@Nadav011
Copy link
Copy Markdown
Owner

Fixes current-head CI/security failures by switching the workflows to the repo's actual npm lockfile model and pinning the Trivy action to the current safe revision.

Copilot AI review requested due to automatic review settings March 29, 2026 12:57
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 29, 2026

Warning

Rate limit exceeded

@Nadav011 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 13 minutes and 37 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 13 minutes and 37 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4aff68b6-f304-4a1e-9dbc-e1f69f9b997b

📥 Commits

Reviewing files that changed from the base of the PR and between 553aff9 and 7615e40.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • .github/workflows/security.yml
  • .github/workflows/trivy-autofix.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/npm-lock-and-trivy

Comment @coderabbitai help to get the list of available commands and usage tips.

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@Nadav011 Nadav011 force-pushed the fix/npm-lock-and-trivy branch from 965c8a1 to 7615e40 Compare March 29, 2026 12:59
@Nadav011 Nadav011 merged commit cace2ff into master Mar 29, 2026
7 of 8 checks passed
@Nadav011 Nadav011 deleted the fix/npm-lock-and-trivy branch March 29, 2026 13:00
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CI/security workflows to match the repository’s npm + package-lock.json setup and to harden Trivy action usage.

Changes:

  • Switch CI install/lint/typecheck steps from pnpm to npm (npm ci, npm run ...).
  • Pin aquasecurity/trivy-action to an immutable commit SHA (annotated as v0.35.0) across workflows.
  • In Trivy auto-fix workflow, regenerate package-lock.json after applying package.json overrides.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/trivy-autofix.yml Pins Trivy action; removes pnpm enablement; adds npm install --package-lock-only after override patching.
.github/workflows/security.yml Pins Trivy action to the same immutable SHA.
.github/workflows/ci.yml Moves CI to npm commands and simplifies CI-gate dependencies; removes prior Node PATH setup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 19 to 22

- name: Add Node.js (fnm) to PATH
run: echo "$HOME/.local/share/fnm/node-versions/v24.14.0/installation/bin" >> $GITHUB_PATH

- name: Enable pnpm via corepack
run: corepack enable pnpm


- name: Install dependencies
run: pnpm install --frozen-lockfile
run: npm ci

Copy link

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint-typecheck runs npm ci/npm run ... on a self-hosted runner but the workflow no longer ensures Node.js is available (no actions/setup-node and no fnm PATH injection). Other workflows in this repo still add the fnm-managed Node v24.14.0 to $GITHUB_PATH, so this job may fail if Node isn’t already on PATH or if a different Node version is picked up. Consider adding back a Node setup step (either actions/setup-node pinned to the expected version or the same fnm PATH export used elsewhere) before npm ci.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants