Skip to content

fix(ci): add vibecoder node path before npm install#6

Merged
Nadav011 merged 1 commit intomasterfrom
fix/vibecoder-node-path
Mar 29, 2026
Merged

fix(ci): add vibecoder node path before npm install#6
Nadav011 merged 1 commit intomasterfrom
fix/vibecoder-node-path

Conversation

@Nadav011
Copy link
Copy Markdown
Owner

@Nadav011 Nadav011 commented Mar 29, 2026

Summary

  • add the fnm-managed Node.js bin path before npm ci in the CI lint/typecheck job
  • keep the rest of the workflow unchanged
  • match the current npm: command not found failure on main exactly

Verification

  • YAML parse check for .github/workflows/ci.yml
  • matched directly to current main failure run 23710607862

Summary by CodeRabbit

  • Chores
    • Updated CI workflow to ensure the correct Node.js version is available during the build process.

Copilot AI review requested due to automatic review settings March 29, 2026 19:34
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@Nadav011 Nadav011 merged commit 5158ae5 into master Mar 29, 2026
7 of 9 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 29, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b0084826-26e6-4f54-bc9c-75b2f8fbfc31

📥 Commits

Reviewing files that changed from the base of the PR and between 2517efe and baff39c.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

Added a new CI step in the lint-typecheck GitHub Actions job that appends the fnm Node.js v24.14.0 installation path to GITHUB_PATH, ensuring Node.js binaries are available before npm ci execution.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/ci.yml
Added a step to append fnm Node.js v24.14.0 installation path ($HOME/.local/share/fnm/node-versions/v24.14.0/installation/bin) to GITHUB_PATH in the lint-typecheck job

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit hops through workflows bright,
Adding paths to make CI right!
With fnm tucked in place,
Node finds its home base!
The linters will smile with delight ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/vibecoder-node-path

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the CI workflow to ensure npm is available on the self-hosted Pop!_OS runner by adding the fnm-managed Node.js bin directory to PATH before dependency installation.

Changes:

  • Add a workflow step that appends the fnm Node.js v24.14.0 installation/bin directory to $GITHUB_PATH prior to npm ci.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- uses: actions/checkout@v4

- name: Add Node.js (fnm) to PATH
run: echo "$HOME/.local/share/fnm/node-versions/v24.14.0/installation/bin" >> $GITHUB_PATH
Copy link

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quote the $GITHUB_PATH file redirection target (e.g., >> "$GITHUB_PATH") to avoid edge cases if the path ever contains spaces or glob characters on the runner.

Suggested change
run: echo "$HOME/.local/share/fnm/node-versions/v24.14.0/installation/bin" >> $GITHUB_PATH
run: echo "$HOME/.local/share/fnm/node-versions/v24.14.0/installation/bin" >> "$GITHUB_PATH"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants