fix(ci): add vibecoder node path before npm install#6
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded a new CI step in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Adjusts the CI workflow to ensure npm is available on the self-hosted Pop!_OS runner by adding the fnm-managed Node.js bin directory to PATH before dependency installation.
Changes:
- Add a workflow step that appends the fnm Node.js v24.14.0
installation/bindirectory to$GITHUB_PATHprior tonpm ci.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Add Node.js (fnm) to PATH | ||
| run: echo "$HOME/.local/share/fnm/node-versions/v24.14.0/installation/bin" >> $GITHUB_PATH |
There was a problem hiding this comment.
Quote the $GITHUB_PATH file redirection target (e.g., >> "$GITHUB_PATH") to avoid edge cases if the path ever contains spaces or glob characters on the runner.
| run: echo "$HOME/.local/share/fnm/node-versions/v24.14.0/installation/bin" >> $GITHUB_PATH | |
| run: echo "$HOME/.local/share/fnm/node-versions/v24.14.0/installation/bin" >> "$GITHUB_PATH" |
Summary
npm ciin the CI lint/typecheck jobnpm: command not foundfailure on main exactlyVerification
.github/workflows/ci.yml23710607862Summary by CodeRabbit