Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I added a cache for read-only (.dat, images, sounds) files to only be loaded into memory once and re-read from there. This reduces the number of I/O accesses to only once per file.
This optimization is not really necessary for normal SDLPop usage as the frequency of I/O access is pretty low. However, it's crucial for the Jaffar bot (and perhaps any other SDLPop based projects) that the I/O accesses are reduced to the minimum possible. In particular, when the bot advances to the new level, it requires re-loading the sprites once per state. Since millions of states advance to the next level at the same time, this breaks the I/O system and crashes the bot. This fix helps in alleviating the pressure.