-
Notifications
You must be signed in to change notification settings - Fork 0
Improve Monomer Input Schema #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
janitha-mahanthe
merged 13 commits into
refactor-into-class-based-structure
from
25-v02-refactor-into-class-based
Mar 3, 2026
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6f7a43c
Refactor ReactionDetector: typing, docs, visuals
janitha-mahanthe 3baf3d0
Add example simulation schema JSON files
janitha-mahanthe 8bb3c3e
Add deprecation warning to detector module
janitha-mahanthe a60ffe2
Update reaction_detector.py
janitha-mahanthe 11556bc
Remove commented-out TODO code block
janitha-mahanthe 5996679
Default force field to PCFF; update warning
janitha-mahanthe 798ee40
Add EmptyReactionListError and selection fix
janitha-mahanthe 597efcc
Add NonReactantsDetector and notebook integration
janitha-mahanthe a694949
Detect and visualize non-reactant monomers
janitha-mahanthe 1efef05
Update non_monomer_detector.py
janitha-mahanthe 158e792
Use replicas schema; add ratio/counts validation
janitha-mahanthe 6596d0f
Update AutoREACTER/input_parser.py
janitha-mahanthe 33fd90a
Update examples/example_1.ipynb
janitha-mahanthe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,53 @@ | ||
| { | ||
| "simulation_name": "Example_Count_Mode", | ||
| "temperature": [300, 400, 500], | ||
| "density": 0.8, | ||
|
|
||
| "composition": { | ||
| "method": "counts", | ||
| "targets": [ | ||
| {"tag": "10k"}, | ||
| {"tag": "100k"} | ||
| ] | ||
| }, | ||
|
|
||
| "monomers": [ | ||
| { | ||
| "name": "tmc", | ||
| "smiles": "ClC(=O)c1cc(cc(c1)C(Cl)=O)C(Cl)=O", | ||
| "count": { | ||
| "10k": 220, | ||
| "100k": 2200 | ||
| } | ||
| }, | ||
| { | ||
| "name": "mpd", | ||
| "smiles": "C1=CC(=CC(=C1)N)N", | ||
| "count": { | ||
| "10k": 220, | ||
| "100k": 2200 | ||
| } | ||
|
|
||
| "simulation_name": "Example_Count_Mode", | ||
|
|
||
| "replicas": { | ||
| "temperatures": [300, 400, 500], | ||
| "density": [0.8], | ||
| "method": "counts", | ||
|
|
||
| "systems": [ | ||
|
|
||
| { | ||
| "tag": "10k", | ||
|
|
||
| "monomer_counts": { | ||
| "tmc": 220, | ||
| "mpd": 220, | ||
| "ethanol": 110 | ||
| } | ||
| }, | ||
|
|
||
| { | ||
| "tag": "100k", | ||
|
|
||
| "monomer_counts": { | ||
| "tmc": 2200, | ||
| "mpd": 2200, | ||
| "ethanol": 1100 | ||
| } | ||
| } | ||
|
|
||
| ] | ||
| }, | ||
| { | ||
| "smiles": "CCO", | ||
| "count": { | ||
| "10k": 110, | ||
| "100k": 1100 | ||
| } | ||
| } | ||
| ] | ||
|
|
||
| "monomers": [ | ||
|
|
||
| { | ||
| "name": "tmc", | ||
| "smiles": "ClC(=O)c1cc(cc(c1)C(Cl)=O)C(Cl)=O" | ||
| }, | ||
|
|
||
| { | ||
| "name": "mpd", | ||
| "smiles": "C1=CC(=CC(=C1)N)N" | ||
| }, | ||
|
|
||
| { | ||
| "name": "ethanol", | ||
| "smiles": "CCO" | ||
| } | ||
|
|
||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,44 @@ | ||
| { | ||
| "simulation_name": "Example_Count_Mode", | ||
| "temperature": [300, 400, 500], | ||
| "density": 0.8, | ||
| "force_field": "PCFF", | ||
| "composition": { | ||
|
|
||
| "replicas": { | ||
| "temperatures": [300, 400, 500], | ||
| "density": [0.8], | ||
| "method": "counts", | ||
| "targets": [ | ||
| {"tag": "10k"}, | ||
| {"tag": "100k"} | ||
|
|
||
| "systems": [ | ||
| { | ||
| "tag": "10k", | ||
| "monomer_counts": { | ||
| "tmc": 220, | ||
| "mpd": 220, | ||
| "data_3": 110 | ||
| } | ||
| }, | ||
| { | ||
| "tag": "100k", | ||
| "monomer_counts": { | ||
| "tmc": 2200, | ||
| "mpd": 2200, | ||
| "data_3": 1100 | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
|
|
||
| "monomers": [ | ||
|
|
||
| "force_field": "PCFF", | ||
|
|
||
| "monomers": [ | ||
| { | ||
| "name": "tmc", | ||
| "smiles": "ClC(=O)c1cc(cc(c1)C(Cl)=O)C(Cl)=O", | ||
| "count": { | ||
| "10k": 220, | ||
| "100k": 2200 | ||
| } | ||
| "smiles": "ClC(=O)c1cc(cc(c1)C(Cl)=O)C(Cl)=O" | ||
| }, | ||
| { | ||
| "name": "mpd", | ||
| "smiles": "C1=CC(=CC(=C1)N)N", | ||
| "count": { | ||
| "10k": 220, | ||
| "100k": 2200 | ||
| } | ||
| "smiles": "C1=CC(=CC(=C1)N)N" | ||
| }, | ||
| { | ||
| "smiles": "CCO", | ||
| "count": { | ||
| "10k": 110, | ||
| "100k": 1100 | ||
| } | ||
| "smiles": "CCO" | ||
| } | ||
janitha-mahanthe marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ] | ||
| } | ||
| } | ||
46 changes: 46 additions & 0 deletions
46
examples/example_1_inputs_count_mode_with_non_monomers.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| { | ||
|
|
||
| "simulation_name": "Example_Count_Mode", | ||
|
|
||
| "replicas": { | ||
| "temperatures": [300, 400, 500], | ||
| "density": [0.8], | ||
| "method": "counts", | ||
|
|
||
| "systems": [ | ||
|
|
||
| { | ||
| "tag": "10k", | ||
|
|
||
| "monomer_counts": { | ||
| "tmc": 220, | ||
| "mpd": 220 | ||
| } | ||
janitha-mahanthe marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }, | ||
|
|
||
| { | ||
| "tag": "100k", | ||
|
|
||
| "monomer_counts": { | ||
| "tmc": 2200, | ||
| "mpd": 2200 | ||
| } | ||
| } | ||
|
|
||
| ] | ||
| }, | ||
|
|
||
| "monomers": [ | ||
|
|
||
| { | ||
| "name": "tmc", | ||
| "smiles": "ClC(=O)c1cc(cc(c1)C(Cl)=O)C(Cl)=O" | ||
| }, | ||
|
|
||
| { | ||
| "name": "mpd", | ||
| "smiles": "C1=CC(=CC(=C1)N)N" | ||
| } | ||
|
|
||
| ] | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.