Enhance system properties and refactor example notebooks#57
Merged
janitha-mahanthe merged 10 commits intorefactor-into-class-based-structurefrom Apr 8, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR advances the v0.2 workflow refactor by updating the input schema to require per-system temperature/density, adding a new top-level CLI entrypoint, and refactoring cache/run-directory handling so REACTER outputs are organized into dated run folders.
Changes:
- Refactored input validation to require
temperatureanddensityperreplicas.systemsand disallow legacyreplicas.temperatures/replicas.density. - Added a new
AutoREACTER.pyCLI orchestrator to run the end-to-end pipeline and move generated artifacts into dated run directories. - Reworked cache management to create/cleanup dated run folders and to move REACTER output files out of the staging cache.
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
AutoREACTER.py |
New CLI entrypoint orchestrating validation → detection → 3D prep → Lunar → REACTER build, plus moving outputs into dated run dirs. |
AutoREACTER/cache.py |
Refactors cache root discovery, dated run dir creation, moving REACTER files, and cleanup behavior. |
AutoREACTER/input_parser.py |
Enforces per-system temperature/density; adds monomer key validation across systems; updates numeric validation behavior. |
AutoREACTER/sim_setup/system_property_calculations.py |
Introduces a new (currently stubbed) system properties helper under sim_setup/. |
AutoREACTER/system_property_calculations.py |
Removes the previous placeholder module at the old location. |
AutoREACTER/main.py |
Removes the previous script-style entrypoint. |
examples/example_1_inputs_ratio_mode.json |
Updates example to per-system temperature/density in ratio mode. |
examples/example_1_inputs_count_mode.json |
Updates example to per-system temperature/density in counts mode and adds an extra system. |
examples/example_1_inputs_count_mode_FF.json |
Updates force-field example to the new per-system temperature/density schema. |
examples/example_1_inputs_count_mode_with_non_monomers.json |
Removes an obsolete example file under the old schema. |
reaction.png |
Adds/updates a reaction image asset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Update _validate_temperature to accept a list of temperatures.
87182f8
into
refactor-into-class-based-structure
1 check failed
This was referenced Apr 8, 2026
Closed
Copilot stopped work on behalf of
janitha-mahanthe due to an error
April 8, 2026 22:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR is to close the issues #55, #56 and #41 along with the main issue of v0.2 #25 releasing, which was addressed over past PRs.
Related PRs
PRs: #54, #48, #47, #45, #44, #43, #42, #39, #37
Changes
AutoREACTER.py
In this PR we have added the AutoREACTER.py which can run by cmd CLI with 3 different flags:
-c→ remove current/past files-help→ show help-in→ input JSONThis will be very useful to users who want to use the package in larger scale and it will also be helpful for developers for debugging.
Input Format
We have modified the input format which has to define each simulation instead of one simulation, because in previous setup it was generating unnecessary simulations (which will reduce the number of unnecessary outputs with 0.2.1 release).
Cache Handling
Also we have added cache handling. In this we move all the generated final files for REACTER to dated designated folders, which will make the output organized.
Validation Updates
Temperature and Density
replicas.temperaturesreplicas.densityMonomer Validation
_validate_system_monomer_keysGeneral Validation
Workflow
Added AutoREACTER.py as main entry point which handles:
Also includes CLI messages and cleanup.