bugfix in scuff-tmatrix #1
Closed
stevengj wants to merge 29 commits intoNanoComp:masterfrom
Closed
Conversation
…ling. All scuff-tmatrix output created before this commit is WRONG (possibly except for unit sphere).
This might not be the most C++ way, but better than the previous state that misbehaved (methods from FIBBICache.cc could be linked from FIPPICache.cc, causing invalid reads and possibly memory corruption).
May break compatibility with non-GNU make due to the $(shell ...) extension.
In scuff-caspol/PolModel::GetPolarizability, MD is used in a conditional statement, without properly initialized in PolModel::InitPolModel_BI
Fixes HomerReid#220 from upstream.
Author
|
Hmm, this didn't work, pulled in too many extraneous commits. Will try again. |
Author
|
Oh nevermind, was already merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of HomerReid#197 to the NanoComp fork