Implement toggle for auto update check on startup#8
Open
numerfolt wants to merge 3 commits intoNastas95:mainfrom
Open
Implement toggle for auto update check on startup#8numerfolt wants to merge 3 commits intoNastas95:mainfrom
numerfolt wants to merge 3 commits intoNastas95:mainfrom
Conversation
This adds a checkbox to the footer, next to the update button. This checkbox is untoggled by default, because it's not clear to the user that it always searches for updates on startup. When the checkbox is toggled, the tool writes the user setting to the database and checks for updates on the next startup. On startup it reads the setting from the database and sets the toggle accordingly.
Use the variable that was read from the database instead of the checkbox toggle status.
Owner
|
This is a nice feature, I'll look into it later this weekend! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is a really cool tool, thanks for creating it!
I dug through the code and noticed that the tool automatically checks for updates on every startup. I didnt know that and thought, it would only check for updates if I pushed the "Check Updates" button.
That's why I implemented a simple toggle (using a Checkbox) and a setting in the database. The setting is read on startup (and defaults to false) and sets the checkbox state. The checkbox state is then used to check whether to check for updates on startup or not.
I only wanted to include this change in the pull request, but don't work with github so often. Which is why I also included a commit that adds a comment about the ignored App IDs. This should make it easier for other people to understand why some apps are ignored :)
Looking back to hear from you!