Add input for ElectricStorage SOC timeseries#486
Open
Conversation
lixiangk1
approved these changes
Apr 17, 2025
Collaborator
|
I reviewed the changes and ran some tests and everything seems to make sense. I was wondering if you've noticed in your runs that the cases with the fixed SOC dispatch returns a slightly lower LCC compared to the fixed sizes but unconstrained dispatch? We'd expect it to be slightly higher if results are different right? Is that just a mathematical tolerance thing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Cherry-picked from branch
h2-tldrd-mpcby @lixiangk1 with a few small mods