Fix/fetch printers

[gwleuverink]

Fixes #20
Fixes #21

Turns out Electron removed some properties we missed in the update:

https://www.electronjs.org/docs/latest/breaking-changes#removed-isdefault-and-status-properties-on-printerinfo

I've removed these properties from the Printer value object. This might be breaking though. Should I retroactively add it to the upgrade guide @simonhamp ?

[gwleuverink]

Changes to the upgrade guide can be found here:

NativePHP/nativephp.com#224

[simonhamp]

Couldn't we just make the parameters optional for now?

[gwleuverink]

We could. They would always be null, so peoples code would not error.

However if they rely on those properties their code would likely stop to work as intended.

If it was me I’d rather see an error. Or alternatively a obvious warning.

[simonhamp]

I mean so that it's not breaking now. We could deprecate, and then pull them out in the next major version?

[gwleuverink]

We could do that, but pardon my confusion. Wouldn't a deprecation mean the feature should keep working?

Because if I set these values to null now, it would not mean the userland code keeps working like before.

[simonhamp]

Because if I set these values to null now, it would not mean the userland code keeps working like before.

Maybe I'm missing something... from the linked issues it sounds like this isn't working right now?

I'm just thinking that removing these would almost certainly cause a BC break for folks relying on them.

But maybe this is only an internal data object and isn't used publicly? Or maybe its usage is minimal (hard to know)?

Just thinking what's the path that lets us avoid a breaking change?

[gwleuverink]

But maybe this is only an internal data object and isn't used publicly? Or maybe its usage is minimal (hard to know)?

It's def a publicly used class

Just thinking what's the path that lets us avoid a breaking change?

I might have a solution based on what @PeteBishwhip suggested 👍🏻 Let me try that right now