Add endpoint to relaunch the app #212
Conversation
Added a new `/relaunch` POST endpoint to restart the app with relaunch options. It uses `app.relaunch` with the current arguments and then quits the app. This ensures a seamless restart process for the application.
SRWieZ
left a comment
SRWieZ
left a comment
There was a problem hiding this comment.
Why adding --relaunch argument ?
It seems unnecessary, and it's there as an example in the docs.
Am I missing something ?
reference: https://www.electronjs.org/docs/latest/api/app#apprelaunchoptions
|
Hi @SRWieZ, Yes, that's exactly what they did in the documentary. I understood that this makes sense because if an application can only have one instance, it can still be restarted in this way. With this argument, it would then be a different instance. |
|
I just watched the docu again, I may have misunderstood it. Should I remove the argument again? |
|
Yeah, I don't think it's necessary. Let's do without it for now. |
Removed unnecessary custom arguments in the `app.relaunch` method. This simplifies the relaunch logic and ensures a cleaner implementation.
|
@SRWieZ I have removed the argument 🙂 |
|
@SRWieZ - Both PRs looks good and are approved. I'll leave the merging to you if you're comfortable that the plugin-build workflow is a flap and not an actual issue. Appears to be related to committing the build, so I would assume it's simply going to resolve on the main branch but I leave that to your professional eyes 👀 @WINBIGFOX - Thank you for your contributions! As usual, you're doing amazing stuff |
3 participants
Added a new
/relaunchPOST endpoint to restart the app with relaunch options. It usesapp.relaunchwith the current arguments and then quits the app. This ensures a seamless restart process for the application.PR:
NativePHP/laravel: NativePHP/laravel#569