-
-
Notifications
You must be signed in to change notification settings - Fork 24
improved PR #85 #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
improved PR #85 #86
Conversation
…/members/properties for name < length
# Conflicts: # dts-generator/gradle/wrapper/gradle-wrapper.properties # dts-generator/src/main/java/com/telerik/dts/DtsApi.java
# Conflicts: # dts-generator/src/main/java/com/telerik/dts/DtsApi.java
# Conflicts: # dts-generator/src/main/java/com/telerik/dts/DtsApi.java
Updates to tackle Kotlin compatibility issues (NativeScript#84)
* handle kotlin parameters without return paramter names with forbidden chars * ensure replaceGenericsInText does not remove > chars far already any types * better detection of open/close namespace to prevent unclosed namespaces * some inner namespaces where not correctly filled/exported
|
@farfromrefug I tested the PR and from my end it's looking good. It seems that you encountered more edge cases than me! Some points from my end:
|
|
Hi @farfromrefug, I was testing again today and something I'd like to highlight is that names are a bit more cryptic now, not sure if it's the intended behaviour or not:
What you see in red is what was generated with the changes I had pushed, green the changes with this branch. If it's intended behaviour I guess not a problem. Just highlighting it just in case. One more inconsistency, double namespace.. which I'm still checking whether it's a generation issue or not: |
|
@dangrima90 seems like there is a bug there. What lib are you testing with? i need to reproduce |
|
@farfromrefug this is the SDKs I'm testing https://github.com/orgs/Mitek-Systems/packages?repo_name=MiSnap-Android. I think you can download the packages from the link I sent. Else you might need to set up a PAT to download the AAR files: https://github.com/Mitek-Systems/MiSnap-Android?tab=readme-ov-file#how-to-integrate-the-misnap-sdk-using-maven. For example, the screenshot above showing |
|
@dangrima90 i dont have credentials for that file. can you share the aar directly by mail ( dev at akylas dot fr) |
|
@farfromrefug unfortunately I'm being blocked from attaching the aar file as an attachment. Just in case you can download the aar file from here: https://github.com/Mitek-Systems/MiSnap-Android/packages/1577915. Screen.Recording.2025-11-13.at.08.39.50.movDoes this help, or you're still not able to access it? |
|
@dangrima90 i downloaded it thanks. But i dont see broken part of |
|
Hi again @farfromrefug, sorry I might have passed a wrong version. Somehow the latest version is listed as This is the same version I'm testing with Here's an example of the changes (same as before, red = my branch, green = your updates 🙂): For reference I've attached the typings file for the core SDK I had generated so that you can compare: misnap-core.d.ts. Sorry for all the back and forth, if you need me to send more samples let me know, it's not a problem. |
|
@dangrima90 both should be fixed now |





This PR add many things which improve typings generation:
Some commits are listed here while already merged