Skip to content

🎨 Palette: Form and Dropzone Accessibility Enhancements#53

Draft
Nawayisus wants to merge 1 commit intomainfrom
palette/a11y-enhancements-17102328423957005379
Draft

🎨 Palette: Form and Dropzone Accessibility Enhancements#53
Nawayisus wants to merge 1 commit intomainfrom
palette/a11y-enhancements-17102328423957005379

Conversation

@Nawayisus
Copy link
Copy Markdown
Owner

🎨 Palette: Form and Dropzone Accessibility Enhancements

💡 What:

  • Added for attributes to all configuration form labels (#sourceLang, #targetLang, #outputFormat, #providerSelect).
  • Made the custom file upload area (#dropZone) keyboard accessible by adding tabindex="0", role="button", and an aria-label.
  • Implemented event listeners for Enter, Space, and full-area clicks on #dropZone while mitigating event bubbling issues with the nested file input.
  • Added ARIA attributes to the progress bar (aria-valuemin, aria-valuemax, aria-valuenow) and dynamically updated them via JavaScript.
  • Added aria-live="polite" to the progress container so screen readers announce dynamic status text updates.

🎯 Why:

  • Previous labels lacked an explicit association with their inputs, making them difficult for screen reader users to understand and harder for mouse users to click.
  • The drag-and-drop zone required a mouse to click the specific "Select File" button; now, keyboard-only users can focus the area and use Enter/Space to open the file dialog.
  • Progress updates were visual-only; they are now announced correctly to assistive technologies.

♿ Accessibility:

  • Significantly improved keyboard navigation, form control context, and dynamic content awareness for screen readers.

📝 Documentation:

  • Logged a critical learning regarding event bubbling in nested interactive dropzones to .Jules/palette.md.

PR created automatically by Jules for task 17102328423957005379 started by @Nawayisus

- Added `for` attributes to language and provider select labels.
- Added `tabindex="0"`, `role="button"`, and `aria-label` to `#dropZone`
  to make the upload area focusable and readable.
- Supported keyboard navigation (Enter/Space) and extended click target
  to the entire `#dropZone` in `js/app.js`, while preventing event
  bubbling to nested inputs.
- Implemented `aria-live="polite"` to `#progressArea` and dynamically
  updated `aria-valuenow` on `#progressBar` for screen reader progress
  announcements.

Co-authored-by: Nawayisus <154715157+Nawayisus@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant