Skip to content

🎨 Palette: Improve accessibility of form labels and dropzone#57

Draft
Nawayisus wants to merge 1 commit intomainfrom
palette-a11y-dropzone-labels-554996492158447727
Draft

🎨 Palette: Improve accessibility of form labels and dropzone#57
Nawayisus wants to merge 1 commit intomainfrom
palette-a11y-dropzone-labels-554996492158447727

Conversation

@Nawayisus
Copy link
Copy Markdown
Owner

This PR implements a micro-UX/Accessibility enhancement to the Universal Document Translator.

It improves keyboard navigation and screen-reader compatibility for the main form:

  • Links <label> tags explicitly to their corresponding <select> elements using for attributes.
  • Makes the #dropZone component keyboard-focusable and reachable via Tab by adding tabindex="0", role="button", and an aria-label.
  • Adds click and keydown (Enter/Space) JavaScript listeners to allow the dropzone to trigger the hidden file input directly, avoiding event bubbling loops.
  • Sets initial aria attributes on the progress bar and dynamically updates aria-valuenow in updateProgress to allow screen readers to track translation status.
  • Adds aria-live="polite" to the progress area.

PR created automatically by Jules for task 554996492158447727 started by @Nawayisus

💡 What: Added `for` attributes to form labels, added `tabindex`, `role="button"`, and `aria-label` to the custom file upload dropzone. Implemented `click` and `keydown` (Enter, Space) event listeners in JS to trigger file upload from the dropzone. Updated `aria-valuenow` dynamically for the progress bar.
🎯 Why: Makes the form fully compatible with screen readers and keyboard navigation, allowing users who cannot use a mouse to upload files and track progress properly.
♿ Accessibility: Ensures form fields have correctly linked labels, dynamic content is announced, and custom components are keyboard-accessible.

Co-authored-by: Nawayisus <154715157+Nawayisus@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant