Conversation
- Added `tabindex="0"` and `role="button"` to `#dropZone` in `index.php`. - Implemented `click` and `keydown` event listeners in `js/app.js` to trigger the file input using `Enter` or `Space`. - Safely delegated click events to prevent double-triggering when clicking nested elements or the hidden file input. - Mapped existing `highlight` and `unhighlight` functions to `focus` and `blur` events for visual feedback. - Documented findings in `.Jules/palette.md`. Co-authored-by: Nawayisus <154715157+Nawayisus@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR addresses the accessibility of the main file upload drop zone. Previously, it could only be interacted with via mouse click or drag-and-drop. This change makes the drop zone fully keyboard accessible.
What: Added keyboard navigation support to the custom
#dropZone.Why: Screen reader and keyboard-only users could not focus on the drop zone or trigger the file selection dialog without a mouse.
Accessibility:
tabindex="0",role="button", and anaria-labelto the drop zone.EnterandSpacekeydown event listeners to trigger file selection.focusandblurlisteners to provide the same visual highlight as mousedragoverevents.PR created automatically by Jules for task 13278730987245068230 started by @Nawayisus